Use gesvd as solver#661
Closed
andompesta wants to merge 2 commits intoNVIDIA:mainfrom
Closed
Conversation
Signed-off-by: scavallari <scavallari@nviia.com>
andompesta
force-pushed
the
scavallari_svd-quant_opt
branch
from
95f9b7e to
c513c47
Compare
Contributor
|
LGTM. As a reference, could you point me to the documentation? |
jingyu-ml
approved these changes
Dec 9, 2025
Collaborator
|
/ok to test c513c47 |
Collaborator
|
@andompesta seems like our SVD Quant tests fail on CPU: https://github.com/NVIDIA/Model-Optimizer/actions/runs/20025754823/job/58410748645?pr=661 FAILED tests/unit/torch/quantization/test_calib.py::test_svdquant_lora_weights
FAILED tests/unit/torch/quantization/test_quantize_cpu.py::test_quantize[config4-SimpleLinear]
FAILED tests/unit/torch/quantization/test_quantize_cpu.py::test_quantize[config4-SimpleConvLinear]
FAILED tests/unit/torch/quantization/test_quantize_cpu.py::test_save_restore[SimpleLinear-quant_config3]RuntimeError: torch.linalg.svd: keyword argument `driver=` is only supported on CUDA inputs with cuSOLVER backend. |
Author
|
I see, I gived it for granted that svd runs on cuda devices |
Collaborator
|
Thanks. One more thing:
Please use |
andompesta
force-pushed
the
scavallari_svd-quant_opt
branch
5 times, most recently
from
79b14a2 to
389728b
Compare
andompesta
force-pushed
the
scavallari_svd-quant_opt
branch
from
389728b to
9fbbbeb
Compare
Collaborator
|
Still failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: ?
Bug fix: default svd solver does not work for ill-conditioned matrixes. Switch to
gesvdsolver as it is more accurate (as per documentation) as does not fails for ill-conditioned matrixesOverview: ?
Usage
# Add a code snippet demonstrating how to use thisTesting
Before your PR is "Ready for review"
Additional Information